Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/Fixes secrets list breadcrumb #13604

Merged
merged 2 commits into from Jan 10, 2022
Merged

UI/Fixes secrets list breadcrumb #13604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f884b88
fixes basekey param
hellobontempo Jan 8, 2022
91f3670
adds changelog
hellobontempo Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/13604.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixes breadcrumb bug for secrets navigation
```
2 changes: 1 addition & 1 deletion ui/app/templates/components/secret-list-header.hbs
View file
Open in desktop
@@ -1,7 +1,7 @@
{{#with (options-for-backend @model.engineType) as |options|}}
<PageHeader as |p|>
<p.top>
<KeyValueHeader @baseKey={{this.baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}>
<KeyValueHeader @baseKey={{@baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, probably a backport to 1.9 because I believe in 1.9 I glimmerized this component and this would be a glimmer issue. Nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monkeychip - from what I could tell this behavior has been happening since before 1.7? But I'll reconfirm next week

<li>
<span class="sep">
/
Expand Down