New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to address a data race issue within identity store - take 2 #13476
Merged
stevendpclark
merged 2 commits into
main
from
stevendpclark/fix-identity-store-data-race-take-2
Dec 22, 2021
Merged
Attempt to address a data race issue within identity store - take 2 #13476
stevendpclark
merged 2 commits into
main
from
stevendpclark/fix-identity-store-data-race-take-2
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
Dec 20, 2021
- Testcase TestIdentityStore_LocalAliasInvalidations identified a data race issue.
- This reverts the previous attempt to address the issue from Address a data race issue within identity_store_util::processLocalAlias #13093
- Ran the test for several hours in a loop without failure, hopefully this will properly fix it this time.
- Testcase TestIdentityStore_LocalAliasInvalidations identified a data race issue. - This reverts the previous attempt to address the issue from #13093
vishalnayak
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
stevendpclark
deleted the
stevendpclark/fix-identity-store-data-race-take-2
branch
December 22, 2021 14:51
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
…ashicorp#13476) * Attempt to address a data race issue within identity store * Testcase TestIdentityStore_LocalAliasInvalidations identified a data race issue. * This reverts the previous attempt to address the issue from hashicorp#13093
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
…ashicorp#13476) * Attempt to address a data race issue within identity store * Testcase TestIdentityStore_LocalAliasInvalidations identified a data race issue. * This reverts the previous attempt to address the issue from hashicorp#13093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.