identity: allow creating a role with a non-existent key #12251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
approved these changes
Aug 4, 2021
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| identity: allow creating a role with a non-existent key | |||
There was a problem hiding this comment.
This was always the case, up until #12151 was introduced right? Since this is a bug fix for a PR within 1.8.1 and results in no behavioral change from the user, I wonder if we can just pr/no-changelog this one.
calvn
pushed a commit
that referenced
this pull request
Aug 4, 2021
* identity: allow creating a role with a non-existent key * remove whitespace * add changelog
calvn
added a commit
that referenced
this pull request
Aug 4, 2021
…ey (#12251) (#12257) * identity: allow creating a role with a non-existent key (#12251) * identity: allow creating a role with a non-existent key * remove whitespace * add changelog * changelog: remove 12251 entry (#12256) Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR maintains the current behavior in 1.8 by ensuring that a role can be created with a non-existent key. Any change to this behavior would be a breaking change for those dependent on it.
Background
#12151 fixed a bug that allowed a role's token_ttl to be longer than the verification_ttl of the key it references. However that PR introduced a bug that would cause the creation of a role with a non-existent key to fail with the error:
Since the current plan is to ship #12151 in 1.8.1 then we need to make sure this PR is also shipped in 1.8.1 to maintain backward compatibility with existing behavior.
Additionally, #12208 is planned to be shipped in 1.9 and will enforce the key param and key existence on role creation.