New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Diagnose Formatting In Disk Usage Checks #12229
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
33292ea
save
HridoyRoy 5454df9
fix diagnose formatting errors
HridoyRoy ae0137f
fix diagnose formatting errors
HridoyRoy e3fe0c5
Merge branch 'main' into diagnose-print-fix
HridoyRoy 5a79ead
change powers
HridoyRoy 7392d48
change powers
HridoyRoy 04fa33c
use humanize instead of doing the conversion to mb manually
HridoyRoy cad6d8e
cl
HridoyRoy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,11 +31,11 @@ partLoop: | |
Warn(ctx, fmt.Sprintf("Could not obtain partition usage for %s: %v.", partition.Mountpoint, err)) | ||
} else { | ||
if usage.UsedPercent > 95 { | ||
SpotWarn(ctx, testName, fmt.Sprintf(partition.Mountpoint+" is %d percent full.", usage.UsedPercent), | ||
Advice("It is recommended to have more than five percent of the partition free.")) | ||
SpotWarn(ctx, testName, fmt.Sprintf(partition.Mountpoint+" is %f percent full.", usage.UsedPercent)) | ||
Advise(ctx, "It is recommended to have more than five percent of the partition free.") | ||
} else if usage.Free < 2<<30 { | ||
SpotWarn(ctx, testName, partition.Mountpoint+" has %d bytes full.", | ||
Advice("It is recommended to have at least 1 GB of space free per partition.")) | ||
SpotWarn(ctx, testName, fmt.Sprintf(partition.Mountpoint+" has %d bytes free.", usage.Free)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bytes can be hard to read when we're talking about 8-9 digits. Maybe show as MBs or MiBs instead? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do! |
||
Advise(ctx, "It is recommended to have at least 1 GB of space free per partition.") | ||
} else { | ||
SpotOk(ctx, testName, partition.Mountpoint+" usage ok.") | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually like to limit the number of digits of precision for float printfs, e.g.
%.2f
. Otherwise it can look ungainly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, didn't realize there was a simple way to make that nicer. Thanks, will do!