Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.8: Fix vault debug so that captured logs include newlines. (#12175) #12201

Merged
merged 6 commits into from Aug 20, 2021
Merged

Backport 1.8: Fix vault debug so that captured logs include newlines. (#12175) #12201

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a10da0
Fix `vault debug` so that captured logs include newlines. (#12175)
ncabatoff Jul 27, 2021
845894a
Merge branch 'release/1.8.x' into backport-pr-12175-1.8
ncabatoff Jul 30, 2021
527125e
Merge branch 'release/1.8.x' into backport-pr-12175-1.8
ncabatoff Aug 5, 2021
f3f3fbf
Merge branch 'release/1.8.x' into backport-pr-12175-1.8
ncabatoff Aug 19, 2021
fff84e6
Merge branch 'release/1.8.x' into backport-pr-12175-1.8
ncabatoff Aug 19, 2021
bfd964d
Merge branch 'release/1.8.x' into backport-pr-12175-1.8
ncabatoff Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/12175.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
cli: vault debug now puts newlines after every captured log line.
```
3 changes: 3 additions & 0 deletions command/debug.go
View file
Open in desktop
Expand Up @@ -1000,6 +1000,9 @@ func (c *DebugCommand) writeLogs(ctx context.Context) {
for {
select {
case log := <-logCh:
if !strings.HasSuffix(log, "\n") {
log += "\n"
}
_, err = out.WriteString(log)
if err != nil {
c.captureError("log", err)
Expand Down