Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identity: do not allow a role's token_ttl to be longer than verification_ttl #12151

Merged
merged 13 commits into from Jul 29, 2021
Merged

identity: do not allow a role's token_ttl to be longer than verification_ttl #12151

merged 13 commits into from Jul 29, 2021

Commits on Jul 22, 2021

  1. do not allow token_ttl to be longer than verification_ttl

    @fairclothjm
    fairclothjm committed Jul 22, 2021
    Copy the full SHA
    e9f8af7 View commit details
    Browse the repository at this point in the history

  2. add verification when updating an existing key 

    When updating a key, ensure any roles referencing the key do not already
have a token_ttl greater than the key's verification_ttl
    @fairclothjm
    fairclothjm committed Jul 22, 2021
    Copy the full SHA
    f2b84c1 View commit details
    Browse the repository at this point in the history

  3. add changelog

    @fairclothjm
    fairclothjm committed Jul 22, 2021
    Copy the full SHA
    606ffd9 View commit details
    Browse the repository at this point in the history

  4. remove unneeded UT check and comment

    @fairclothjm
    fairclothjm committed Jul 22, 2021
    Copy the full SHA
    fc98fc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. refactor based on PR comments 

    - remove make slice in favor of var delcaration
- remove unneeded if check
- validate expiry value during token generation
- update changelog as bug
    @fairclothjm
    fairclothjm committed Jul 23, 2021
    Copy the full SHA
    46bbfb2 View commit details
    Browse the repository at this point in the history

  2. refactor get roles referencing target key names logic

    @fairclothjm
    fairclothjm committed Jul 23, 2021
    Copy the full SHA
    1f7c6dc View commit details
    Browse the repository at this point in the history

  3. add note about thread safety to helper func

    @fairclothjm
    fairclothjm committed Jul 23, 2021
    Copy the full SHA
    e714df7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. update func comment

    @fairclothjm
    fairclothjm committed Jul 26, 2021
    Copy the full SHA
    7b2cbb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. sort array and refactor func names

    @fairclothjm
    fairclothjm committed Jul 27, 2021
    Copy the full SHA
    5dddaf5 View commit details
    Browse the repository at this point in the history

  2. add warning to return response

    @fairclothjm
    fairclothjm committed Jul 27, 2021
    Copy the full SHA
    217bb1a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into oidc-token-ttl-cap

    @fairclothjm
    fairclothjm committed Jul 27, 2021
    Copy the full SHA
    14fe9f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. remove unnecessary code from unit test

    @fairclothjm
    fairclothjm committed Jul 28, 2021
    Copy the full SHA
    d0d4a9b View commit details
    Browse the repository at this point in the history

  2. Update vault/identity_store_oidc.go 

    Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
    @fairclothjm @austingebauer
    fairclothjm and austingebauer committed Jul 28, 2021
    Copy the full SHA
    3d67ba2 View commit details
    Browse the repository at this point in the history