Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: AWS KMS updates for key management secrets engine #11958

Merged
merged 3 commits into from Jun 29, 2021
Merged

docs: AWS KMS updates for key management secrets engine #11958

merged 3 commits into from Jun 29, 2021

Conversation

austingebauer
Copy link
Member

This PR updates the key management secrets engine documentation for the AWS KMS provider.

The following updates are made:

  • Removes beta notices for upcoming GA of the feature
  • Adds a section to explain the key rotation strategy for AWS KMS keys

@austingebauer austingebauer added this to the 1.8 milestone Jun 29, 2021
jasonodonnell
jasonodonnell approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel vercel bot temporarily deployed to Preview – vault-storybook June 29, 2021 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 29, 2021 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 29, 2021 16:54 Inactive
@austingebauer austingebauer merged commit 60aa80d into main Jun 29, 2021
@austingebauer austingebauer deleted the docs-kmse branch June 29, 2021 17:31
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@austingebauer @jartek
docs: AWS KMS updates for key management secrets engine (hashicorp#11958
b56e89d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

@pcman312 pcman312 Awaiting requested review from pcman312

@calvn calvn Awaiting requested review from calvn

@fairclothjm fairclothjm Awaiting requested review from fairclothjm

@MilenaHC MilenaHC Awaiting requested review from MilenaHC

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austingebauer @jasonodonnell