Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ - Add username customization #11899

Merged
merged 6 commits into from Jun 22, 2021
Merged

RabbitMQ - Add username customization #11899

merged 6 commits into from Jun 22, 2021

Conversation

MilenaHC
Copy link
Contributor

Adds the ability to customize username generation for dynamic users in RabbitMQ.

Uses the new field username_template with the go template language.

@MilenaHC MilenaHC added this to the 1.8 milestone Jun 18, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 18, 2021 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 18, 2021 21:10 Inactive
@MilenaHC MilenaHC requested a review from calvn June 18, 2021 21:23
tomhjp
tomhjp reviewed Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Just some nits, and I think the API docs can get updated in this PR as well: website/content/api-docs/secret/rabbitmq.mdx.

builtin/logical/rabbitmq/path_config_connection.go Outdated Show resolved Hide resolved
builtin/logical/rabbitmq/path_config_connection.go Show resolved Hide resolved
builtin/logical/rabbitmq/path_config_connection_test.go Show resolved Hide resolved
builtin/logical/rabbitmq/path_role_create_test.go Show resolved Hide resolved
@MilenaHC @tomhjp
Update builtin/logical/rabbitmq/path_config_connection.go
52d9229 
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 21, 2021 16:50 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 21, 2021 16:50 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 22, 2021 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 22, 2021 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 22, 2021 14:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 22, 2021 14:59 Inactive
tomhjp
tomhjp approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jasonodonnell
jasonodonnell approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: !

@MilenaHC MilenaHC merged commit de4295b into main Jun 22, 2021
@kalafut kalafut deleted the rabbitmq-username-customization branch June 22, 2021 20:09
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@MilenaHC @tomhjp @jartek
RabbitMQ - Add username customization (hashicorp#11899)
db9a104 
* add username customization for rabbitmq

* add changelog for rabbitmq

* Update builtin/logical/rabbitmq/path_config_connection.go

Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>

* updating API docs

* moved to changelog folder

Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

@tomhjp tomhjp tomhjp approved these changes

@pcman312 pcman312 Awaiting requested review from pcman312

@austingebauer austingebauer Awaiting requested review from austingebauer

@calvn calvn Awaiting requested review from calvn

Assignees
No one assigned
Labels
secret/rabbitmq
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MilenaHC @jasonodonnell @tomhjp