Backport 1.8.x: Acquire a per-lock lease to make renew and revoke atomic wrt each oth… #11808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. (#11122) * Acquire a per-lock lease to make renew and revoke atomic wrt each other. This means we don't have to hold pendingLock during I/O. * Attempted fix for deadlock in token revocation. * Comment fix. * Fix error checking in loadEntry. * Add benchmark * Add a few additional locking locations * Improve benchmark slightly * Update vault/expiration.go Co-authored-by: swayne275 <swayne275@gmail.com> * Update vault/expiration.go Co-authored-by: swayne275 <swayne275@gmail.com> * Add a lease lock into tidy Co-authored-by: Scott Miller <smiller@hashicorp.com> Co-authored-by: Brian Kassouf <bkassouf@hashicorp.com> Co-authored-by: Brian Kassouf <briankassouf@users.noreply.github.com> Co-authored-by: swayne275 <swayne275@gmail.com>
swayne275
reviewed
Jun 10, 2021
swayne275
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er. (#11122)
Acquire a per-lock lease to make renew and revoke atomic wrt each other.
This means we don't have to hold pendingLock during I/O.
Attempted fix for deadlock in token revocation.
Comment fix.
Fix error checking in loadEntry.
Add benchmark
Add a few additional locking locations
Improve benchmark slightly
Update vault/expiration.go
Update vault/expiration.go
Add a lease lock into tidy