New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/client: provide the ability to set a logger on retryablehttp.Client #11696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
approved these changes
May 26, 2021
calvn
added a commit
that referenced
this pull request
May 27, 2021
calvn
added a commit
that referenced
this pull request
May 27, 2021
3 tasks
AndreyZamyslov
pushed a commit
to yandex-cloud/vault
that referenced
this pull request
Jun 10, 2021
…nt (hashicorp#11696) * api/client: provide the ability to set a logger on retryablehttp.Client * go mod tidy; fix import ordering * go mod vendor
AndreyZamyslov
pushed a commit
to yandex-cloud/vault
that referenced
this pull request
Jun 10, 2021
* changelog: add entry for hashicorp#11696 * Update 11696.txt * Update 11696.txt
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
…nt (hashicorp#11696) * api/client: provide the ability to set a logger on retryablehttp.Client * go mod tidy; fix import ordering * go mod vendor
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* changelog: add entry for hashicorp#11696 * Update 11696.txt * Update 11696.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set a logger on
api.Client
which is used on its underlyingretryablehttp.Client
instance when making requests. This value is nil by default and is only non-empty if set explicitly to maintain backwards compatibility and to avoid any unexpected output or noise that might result from it otherwise. Note that even thoughretryablehttp.Client
accepts aninterface{}
as a logger to allow for either non-leveled or leveled loggers to be provided, I'm enforcing a leveled logger (e.g.hclog
) to be provided to ourapi/client
package.As a concrete example, setting an
hclog.Logger
, which satisfies theretryablehttp.LevelLogger
interface, on agent's proxy layer allows us to output the number of retry attempts that the client makes.Without a logger:
With a logger: