Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Auth: Update error message to include underlying error #11638

Merged
merged 2 commits into from May 17, 2021
Merged

AWS Auth: Update error message to include underlying error #11638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41421eb
Update error message to include underlying error
pcman312 May 17, 2021
18e0487
Add changelog
pcman312 May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtin/credential/aws/path_login.go
View file
Open in desktop
Expand Up @@ -1364,7 +1364,7 @@ func (b *backend) pathLoginUpdateIam(ctx context.Context, req *logical.Request,
if roleEntry.InferredEntityType == ec2EntityType {
instance, err := b.validateInstance(ctx, req.Storage, entity.SessionInfo, roleEntry.InferredAWSRegion, callerID.Account)
if err != nil {
return logical.ErrorResponse(fmt.Sprintf("failed to verify %s as a valid EC2 instance in region %s", entity.SessionInfo, roleEntry.InferredAWSRegion)), nil
return logical.ErrorResponse("failed to verify %s as a valid EC2 instance in region %s: %s", entity.SessionInfo, roleEntry.InferredAWSRegion, err), nil
calvn marked this conversation as resolved.
Show resolved Hide resolved
}

// build a fake identity doc to pass on metadata about the instance to verifyInstanceMeetsRoleRequirements
Expand Down
3 changes: 3 additions & 0 deletions changelog/11638.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:improvement
auth/aws: Underlying error included in validation failure message.
```