Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Regex validation on transform templates #11586

Merged
merged 3 commits into from May 12, 2021

Conversation

hashishaw
Copy link
Collaborator

  • Add regex validator component and tests
  • Use in form for transform template create/edit

The validator does not block the input in any way, just provides extra information about whether the test string matches the regex. Transform templates expect the entire string to match the regex or else it fails, so that's how this component works as well.

regex-validator-template

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@vercel vercel bot temporarily deployed to Preview – vault-storybook May 12, 2021 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview – vault May 12, 2021 14:48 Inactive
@hashishaw hashishaw merged commit a9c2b72 into master May 12, 2021
@hashishaw hashishaw deleted the ui/transform-template-regex-validation branch May 12, 2021 15:12
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
* Add regex validator component with tests, add to form-field, use in transform template

* Update tests with data-test selectors

* Add changelog
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* Add regex validator component with tests, add to form-field, use in transform template

* Update tests with data-test selectors

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants