Update GCP auth docs for signJwt transition to Service Account Credentials API #11568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
approved these changes
May 11, 2021
AndreyZamyslov
pushed a commit
to yandex-cloud/vault
that referenced
this pull request
Jun 10, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates documentation for the GCP auth method of Vault and Vault agent. It replaces all usage of the deprecated IAM signJwt API with the Service Account Credentials signJwt API. It also removes appropriate instances of the
projectparameter, which is no longer needed.I was able to successfully test the manual JWT signing instructions in the GCP auth method docs. See the migrating-to-credentials-api#jwt-rest for details on the requirement of the
expclaim using the new signJWT API. The login helper and agent auth code always provide theexpclaim, so only the recommendations in the docs needed updating.The related PRs provide a more detailed description of the changes that were made.
Related PRs