New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide 'sys/step-down' and 'vault step-down' #1146
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6b0c692
Provide 'sys/step-down' and 'vault step-down'
jefferai ef4466d
Address review feedback
jefferai d0ec85f
Update doc, it's now 10 seconds
jefferai 2a347d2
Merge branch 'master' into step-down
jefferai 1ae2f2f
Remove unneeded sleeps in test code
jefferai 4e964a6
Add default case for if the step down channel is blocked
jefferai File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package api | ||
|
||
func (c *Sys) StepDown() error { | ||
r := c.c.NewRequest("PUT", "/v1/sys/step-down") | ||
resp, err := c.c.RawRequest(r) | ||
if err == nil { | ||
defer resp.Body.Close() | ||
} | ||
return err | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
package command | ||
|
||
import ( | ||
"fmt" | ||
"strings" | ||
) | ||
|
||
// StepDownCommand is a Command that seals the vault. | ||
type StepDownCommand struct { | ||
Meta | ||
} | ||
|
||
func (c *StepDownCommand) Run(args []string) int { | ||
flags := c.Meta.FlagSet("step-down", FlagSetDefault) | ||
flags.Usage = func() { c.Ui.Error(c.Help()) } | ||
if err := flags.Parse(args); err != nil { | ||
return 1 | ||
} | ||
|
||
client, err := c.Client() | ||
if err != nil { | ||
c.Ui.Error(fmt.Sprintf( | ||
"Error initializing client: %s", err)) | ||
return 2 | ||
} | ||
|
||
if err := client.Sys().StepDown(); err != nil { | ||
c.Ui.Error(fmt.Sprintf("Error stepping down: %s", err)) | ||
return 1 | ||
} | ||
|
||
return 0 | ||
} | ||
|
||
func (c *StepDownCommand) Synopsis() string { | ||
return "Force the Vault node to give up active duty" | ||
} | ||
|
||
func (c *StepDownCommand) Help() string { | ||
helpText := ` | ||
Usage: vault step-down [options] | ||
Force the Vault node to step down from active duty. | ||
This causes the indicated node to give up active status. Note that while the | ||
affected node will have a short delay before attempting to grab the lock | ||
again, if no other node grabs the lock beforehand, it is possible for the | ||
same node to re-grab the lock and become active again. | ||
General Options: | ||
` + generalOptionsUsage() | ||
return strings.TrimSpace(helpText) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should guard this with a default case in case there is no listener on the other side to avoid blocking.