Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on renewing a renewable KV v1 secret #118

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix panic on renewing a renewable KV v1 secret #118

wants to merge 3 commits into from

Commits on Jul 25, 2023

  1. Fix panic on renewing a renewable KV v1 secret 

    A regression was introduced in hashicorp#17, in 2018. Better late than never,
let's fix it. This will open the door to considering deleting the second
copy of the KV v1 source code within the Vault repo, and just referring
to this as the canonical copy.

The fix selectively reverts some parts of hashicorp#17, renames `handleRead` to
`handleReadOrRenew`, and adds some detailed comments to explain the
subtlety.
    @maxb
    maxb committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e48f3ee View commit details
    Browse the repository at this point in the history

  2. Oops, forgot to commit this file

    @maxb
    maxb committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4fbd309 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Merge branch 'main' into fix-panic-on-renew

    @maxb
    maxb committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b18492d View commit details
    Browse the repository at this point in the history