Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auth metadata to be configured #90

Closed
wants to merge 3 commits into from

Conversation

tyrannosaurus-becks
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks commented Apr 24, 2020

This draft PR shows the approach being currently pursued to add the ability to configure auth metadata at the role level.

Although it was added at the identity/config endpoint in a different auth engine, it was added at the role level in this one because that's where the aliases are also currently configured, so I thought it made sense to keep them together.

TODO

@kalafut
Copy link
Contributor

kalafut commented Apr 26, 2020

@tyrannosaurus-becks @pcman312 I've been playing with this for both IAM and GCE and it seems to work fine. My main feedback is that we probably want this new configuration (both alias name and metadata) at the top level /config object, similar to AWS. (AWS has an additional "identity" level which doesn't apply here, but the configuration is still for the whole backend, not by role.) Per-role configuration is a potential future enhancement.

@tyrannosaurus-becks
Copy link
Contributor Author

Deleting this branch because there are upstream conflicting changes, and the fields also need to be on the config, so it'll be faster to take off a fresh branch than continue with this one.

@tyrannosaurus-becks tyrannosaurus-becks deleted the gcp-auth-metadata branch April 27, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants