Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Remove equivalent policy check for token renewals #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Remove equivalent policy check for token renewals #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions plugin/path_login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"github.com/hashicorp/go-gcp-common/gcputil"
"github.com/hashicorp/vault/sdk/framework"
"github.com/hashicorp/vault/sdk/helper/cidrutil"
"github.com/hashicorp/vault/sdk/helper/policyutil"
"github.com/hashicorp/vault/sdk/helper/strutil"
"github.com/hashicorp/vault/sdk/logical"
"google.golang.org/api/cloudresourcemanager/v1"
Expand Down Expand Up @@ -99,8 +98,6 @@ func (b *GcpAuthBackend) pathLoginRenew(ctx context.Context, req *logical.Reques
return nil, err
} else if role == nil {
return logical.ErrorResponse("role '%s' no longer exists"), nil
} else if !policyutil.EquivalentPolicies(role.Policies, req.Auth.Policies) {
return logical.ErrorResponse("policies on role '%s' have changed, cannot renew"), nil
}

switch role.RoleType {
Expand Down