Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support workload identity federation #151

Merged
merged 11 commits into from May 8, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Apr 26, 2024

This PR adds plugin WIF support to the Azure auth method. The following new fields are added to the config endpoint to enable configuring Workload Identity Federation:

  • identity_token_audience
  • identity_token_ttl

@fairclothjm fairclothjm marked this pull request as ready for review April 26, 2024 20:29
@thyton thyton self-requested a review May 2, 2024 20:36
Copy link

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for reorganizing and refactoring the tests!

azure.go Show resolved Hide resolved
Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the setup and was able to successfully use the WIF flow. Great job! 👏 🎉

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit 52ae174 into main May 8, 2024
4 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-25159/workload-identity-federation branch May 8, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants