Prep for independent release; update deps #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had to update the API version since the 2018 preview API was dropped in the latest Azure SDK.
fairclothjm
approved these changes
Mar 27, 2023
tvoran
reviewed
Mar 27, 2023
Comment on lines
+10
to
+12
| * `github.com/Azure/azure-sdk-for-go` v67.2.0+incompatible -> v68.0.0+incompatible | ||
| * `github.com/Azure/azure-sdk-for-go/sdk/azcore` v1.3.1 -> v1.4.0 | ||
| * `github.com/Azure/azure-sdk-for-go/sdk/azidentity` v1.2.1 -> v1.2.2 |
There was a problem hiding this comment.
These dep updates going into a patch release worry me a bit while this plugin is bundled with Vault. Since v0.13.0 of this plugin has already been bundled into Vault 1.13, I wonder if these dep updates warrant a minor version increment of the plugin instead? (i.e. v0.14.0 instead of v0.13.1)
There was a problem hiding this comment.
No problem. I'm happy to do a minor release.
tvoran
approved these changes
Mar 27, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to update the API version since the 2018 preview API was dropped in the latest Azure SDK.