Support disable_keep_alives #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up for hashicorp/vault#16479, which added support for `disable_keep_alives` This is used very similarly to `disable_idle_connections`, which was added in #366 This adds the `disable_keep_alives` setting into the injected agent's config, which can be specified per pod: ```yaml metadata: annotations: vault.hashicorp.com/agent-disable-keep-alives: "auto-auth,caching,templating" ``` globally in the injector through the helm command when deploying: ```sh helm install vault hashicorp/vault \ --set injector.extraEnvironmentVars.AGENT_INJECT_DISABLE_KEEP_ALIVES="auto-auth\,caching\,templating" ``` or through the helm `values.yaml` file: ```yaml injector: extraEnvironmentVars: AGENT_INJECT_DISABLE_KEEP_ALIVES: "auto-auth,caching,templating" ``` This was copied almost verbatim from #366, so thanks @tvoran :) Co-authored-by: Theron Voran <theron@hashicorp.com>
tvoran
approved these changes
Jul 28, 2022
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
|
Changelog added. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for hashicorp/vault#16479, which
added support for
disable_keep_alivesThis is used very similarly to
disable_idle_connections, which wasadded in #366
This adds the
disable_keep_alivessetting into the injected agent'sconfig, which can be specified per pod:
globally in the injector through the helm command when deploying:
helm install vault hashicorp/vault \ --set injector.extraEnvironmentVars.AGENT_INJECT_DISABLE_KEEP_ALIVES="auto-auth\,caching\,templating"or through the helm
values.yamlfile:This was copied almost verbatim from #366, so thanks @tvoran :)
Co-authored-by: Theron Voran theron@hashicorp.com