Add TF_STATE_PERSIST_INTERVAL environment variable.
#35176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Ott <alexott@gmail.com>
|
Still missing updating the docs and adding a few more tests, if possible. |
brandonc
reviewed
May 17, 2024
alexott
reviewed
May 17, 2024
sebasslash
force-pushed
the
sebasslash/tf-15302_modifiable-snapshot-interval
branch
from
2993d8b
to
2c03fea
Compare
sebasslash
force-pushed
the
sebasslash/tf-15302_modifiable-snapshot-interval
branch
from
2c03fea
to
5a625a3
Compare
brandonc
approved these changes
May 17, 2024
rkoron007
approved these changes
May 17, 2024
sebasslash
force-pushed
the
sebasslash/tf-15302_modifiable-snapshot-interval
branch
from
5a625a3
to
b28c8bf
Compare
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from the initial work done by @alexott (#35116), which fixes #35115. These changes are a simple refactor to delegate handling this env var to
command.Meta. This allows us to pass the user specified persist interval tobackendrun.Operationand keep env var handling (with existing vars such asTF_WORKSPACE,TF_INPUT) centralized withincommand.Meta.The default interval remains 20 seconds and serves as a global minimum interval. Remote backends such as
cloudmay override the default using theX-Terraform-Snapshot-Intervalheader. If the default interval value is greater than the user-specified value, the default will be used.Target Release
1.9.x
Draft CHANGELOG entry
ENHANCEMENTS