generate precise resource types during validate #29862
Conversation
Allow `GetResource` to return correct types values during validation, rather than relying on `cty.DynamicVal` as a placeholder. This allows other dependent expressions to be more correctly evaluated.
We only lookup providers by provider type to get the schema, so there's no reason to generate anything more specific.
| // since the plan was not yet created during validate, the values we | ||
| // collected here may not correspond with configuration, so they must be | ||
| // unknown. | ||
| if d.Operation == walkValidate { |
There was a problem hiding this comment.
This section was redundant with the default case before we checked the instance state, since there is no instance state during validation. Verified that this condition was no longer reached during tests.
| @@ -1,4 +1,4 @@ | |||
| resource "aws_instance" "web" { | |||
| foo = "${aws_instance.web.*.foo}" | |||
There was a problem hiding this comment.
improved evaluation found a very old invalid test which was assigning a list(list(string)) to a list(string) (though that could have been flattened in the legacy type system, but was never caught post-0.12)
There was a problem hiding this comment.
Nice!
I'm assume that since this is only adding more information to validation there shouldn't be anything new this will catch that wouldn't have been subsequently caught during planning before. That therefore makes this consistent with our compatibility promises, where we promised compatibility only for configurations that could previously get through the full validate/plan/apply sequence without encountering any errors (because we always consider it an improvement to catch an existing problem in an earlier phase than we were able to before).
jbardin
added
the
1.1-backport
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Allow
GetResourceto return correctly typed values during validation, rather than relying oncty.DynamicValas a placeholder. This allows other dependent expressions to be more correctly evaluated.There is no reason we must use the stored state to find the provider address for evaluation. We don't need the exact provider instance here, since we are only looking for the schema and the schema lookup is done with a simple provider type.
Once we have the resource type, we can return correctly shaped unknown values for validation based on the expansion mode of the resource configuration.
Fixes the specific case shown in #29809