Modifying refresh tests to use the option to check expect non-empty p…

…lan added in hashicorp/terraform-plugin-sdk#1070 (#268)
hashicorp · Oct 6, 2022 · 5cf8851 · 5cf8851
1 parent 60601c7
commit 5cf8851
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/internal/provider/resource_locally_signed_cert_test.go b/internal/provider/resource_locally_signed_cert_test.go
@@ -211,10 +211,10 @@ func TestResourceLocallySignedCert_DetectExpiring_Refresh(t *testing.T) {
 				Check:  r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "false"),
 			},
 			{
-				PreConfig:    setTimeForTest("2019-06-14T21:30:00Z"),
-				Config:       locallySignedCertConfig(10, 2),
-				RefreshState: true,
-				Check:        r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "true"),
+				PreConfig:          setTimeForTest("2019-06-14T21:30:00Z"),
+				RefreshState:       true,
+				ExpectNonEmptyPlan: true,
+				Check:              r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "true"),
 			},
 			{
 				PreConfig:          setTimeForTest("2019-06-14T21:30:00Z"),
@@ -238,10 +238,10 @@ func TestResourceLocallySignedCert_DetectExpired_Refresh(t *testing.T) {
 				Check:  r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "false"),
 			},
 			{
-				PreConfig:    setTimeForTest("2019-06-14T23:30:00Z"),
-				Config:       locallySignedCertConfig(10, 2),
-				RefreshState: true,
-				Check:        r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "true"),
+				PreConfig:          setTimeForTest("2019-06-14T23:30:00Z"),
+				RefreshState:       true,
+				ExpectNonEmptyPlan: true,
+				Check:              r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "true"),
 			},
 			{
 				PreConfig:          setTimeForTest("2019-06-14T23:30:00Z"),

diff --git a/internal/provider/resource_self_signed_cert_test.go b/internal/provider/resource_self_signed_cert_test.go
@@ -229,10 +229,10 @@ func TestResourceSelfSignedCert_DetectExpiring_Refresh(t *testing.T) {
 				Check:  r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "false"),
 			},
 			{
-				PreConfig:    setTimeForTest("2019-06-14T21:30:00Z"),
-				Config:       selfSignedCertConfig(10, 2),
-				RefreshState: true,
-				Check:        r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "true"),
+				PreConfig:          setTimeForTest("2019-06-14T21:30:00Z"),
+				RefreshState:       true,
+				ExpectNonEmptyPlan: true,
+				Check:              r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "true"),
 			},
 			{
 				PreConfig:          setTimeForTest("2019-06-14T21:30:00Z"),
@@ -256,10 +256,10 @@ func TestResourceSelfSignedCert_DetectExpired_Refresh(t *testing.T) {
 				Check:  r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "false"),
 			},
 			{
-				PreConfig:    setTimeForTest("2019-06-14T23:30:00Z"),
-				Config:       selfSignedCertConfig(10, 2),
-				RefreshState: true,
-				Check:        r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "true"),
+				PreConfig:          setTimeForTest("2019-06-14T23:30:00Z"),
+				RefreshState:       true,
+				ExpectNonEmptyPlan: true,
+				Check:              r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "true"),
 			},
 			{
 				PreConfig:          setTimeForTest("2019-06-14T23:30:00Z"),