Amending tests to verify following plan apply no further diff remains (…

…#268)
hashicorp · Oct 13, 2022 · 3a89efb · 3a89efb
1 parent 284988d
commit 3a89efb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 16 deletions.
diff --git a/internal/provider/resource_locally_signed_cert_test.go b/internal/provider/resource_locally_signed_cert_test.go
@@ -217,10 +217,9 @@ func TestResourceLocallySignedCert_DetectExpiring_Refresh(t *testing.T) {
 				Check:              r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "true"),
 			},
 			{
-				PreConfig:          setTimeForTest("2019-06-14T21:30:00Z"),
-				Config:             locallySignedCertConfig(10, 2),
-				PlanOnly:           true,
-				ExpectNonEmptyPlan: true,
+				PreConfig: setTimeForTest("2019-06-14T21:30:00Z"),
+				Config:    locallySignedCertConfig(10, 2),
+				Check:     r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "false"),
 			},
 		},
 	})
@@ -244,10 +243,9 @@ func TestResourceLocallySignedCert_DetectExpired_Refresh(t *testing.T) {
 				Check:              r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "true"),
 			},
 			{
-				PreConfig:          setTimeForTest("2019-06-14T23:30:00Z"),
-				Config:             locallySignedCertConfig(10, 2),
-				PlanOnly:           true,
-				ExpectNonEmptyPlan: true,
+				PreConfig: setTimeForTest("2019-06-14T23:30:00Z"),
+				Config:    locallySignedCertConfig(10, 2),
+				Check:     r.TestCheckResourceAttr("tls_locally_signed_cert.test", "ready_for_renewal", "false"),
 			},
 		},
 	})

diff --git a/internal/provider/resource_self_signed_cert_test.go b/internal/provider/resource_self_signed_cert_test.go
@@ -235,10 +235,9 @@ func TestResourceSelfSignedCert_DetectExpiring_Refresh(t *testing.T) {
 				Check:              r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "true"),
 			},
 			{
-				PreConfig:          setTimeForTest("2019-06-14T21:30:00Z"),
-				Config:             selfSignedCertConfig(10, 2),
-				PlanOnly:           true,
-				ExpectNonEmptyPlan: true,
+				PreConfig: setTimeForTest("2019-06-14T21:30:00Z"),
+				Config:    selfSignedCertConfig(10, 2),
+				Check:     r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "false"),
 			},
 		},
 	})
@@ -262,10 +261,9 @@ func TestResourceSelfSignedCert_DetectExpired_Refresh(t *testing.T) {
 				Check:              r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "true"),
 			},
 			{
-				PreConfig:          setTimeForTest("2019-06-14T23:30:00Z"),
-				Config:             selfSignedCertConfig(10, 2),
-				PlanOnly:           true,
-				ExpectNonEmptyPlan: true,
+				PreConfig: setTimeForTest("2019-06-14T23:30:00Z"),
+				Config:    selfSignedCertConfig(10, 2),
+				Check:     r.TestCheckResourceAttr("tls_self_signed_cert.test1", "ready_for_renewal", "false"),
 			},
 		},
 	})