Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acceptance test to reflect Project rename bugfix with go-tfe v1.16.0 upgrade #719

Merged
merged 1 commit into from Dec 12, 2022

Conversation

sebasslash
Copy link
Contributor

Description

The title is a concise summary 馃摉 and this PR closes #714

The fix was actually implemented in our go-tfe dependency here (released in v1.16).

The go-tfe library was validating project names as external IDs, of which inner spaces would result in a validation error. go-tfe was upgraded here.

I've updated the tfe_project resource Update test and changed the name attribute to include an inner space to reflect the fix 馃槃

Testing plan

Acceptance Test

ENABLE_BETA=1 TESTARGS="-run TestAccTFEProject_update" make testacc

Smoke Test

  1. Apply this config:
resource "tfe_project" "foo" {
  name = "a project name with spaces"
  organization = "<my_org_name>"
}

@sebasslash sebasslash merged commit 91b1804 into main Dec 12, 2022
@sebasslash sebasslash deleted the project-rename-fix branch December 12, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfe project rename
2 participants