Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation : OPA support for policies and policy sets #694

Merged
merged 2 commits into from Nov 28, 2022

Conversation

mrinalirao
Copy link
Contributor

Description

Add docs for OPA support to the tfe-provider for policies and policy sets. OPA is still in beta phase.

Screenshots:
r/tfe_policy
registry terraform io_tools_doc-preview

r/tfe_policy_set
registry terraform io_tools_doc-preview (1)

d/tfe_policy_set
registry terraform io_tools_doc-preview (2)

Related PRs
#690
#691

Testing plan

NA

External links

go-tfe Policy Set documentation
go-tfe Policy documentation
API Policy Set documentation
API Policy documentation
JIRA
Related PRs:
#690
#691

Output from acceptance tests

NA

@mrinalirao mrinalirao requested a review from a team as a code owner November 17, 2022 00:31
@mrinalirao mrinalirao changed the title Add OPA support for policies and policy sets Add Documentation : OPA support for policies and policy sets Nov 17, 2022
@mrinalirao
Copy link
Contributor Author

Note: The existing documentation is incorrect
https://registry.terraform.io/providers/hashicorp/tfe/latest/docs/resources/sentinel_policy
Screen Shot 2022-11-18 at 4 20 02 pm

The enforce_mode is not "required" (see : https://github.com/hashicorp/terraform-provider-tfe/blob/main/tfe/resource_tfe_sentinel_policy.go#L50)

This will be addressed in a separate PR and changed for both tfe_sentinel_policy as well as tfe_policy

@mrinalirao mrinalirao merged commit dc6ed15 into main Nov 28, 2022
@mrinalirao mrinalirao deleted the mr/TF-1451-docs branch November 28, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants