Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce no-code modules in registry modules #673

Merged
merged 9 commits into from Nov 18, 2022
Merged

Introduce no-code modules in registry modules #673

merged 9 commits into from Nov 18, 2022

Conversation

miguelhrocha
Copy link
Contributor

@miguelhrocha miguelhrocha commented Oct 26, 2022 •
edited

Description

This PR is a follow-up of hashicorp/go-tfe#562, which adds the no_code module attribute to the registry module resource. This will enable practitioners to bootstrap modules in their TFE instance set up for no-code workspace provisioning.

This change is dependent on the go-tfe PR mentioned before, once that merge this PR will be ready for review.

External links

Output from acceptance tests

TESTARGS="-run TestAccTFERegistryModule_noCodeModule" envchain tfe-provider make testacc
TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFERegistryModule_noCodeModule -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFERegistryModule_noCodeModule
--- PASS: TestAccTFERegistryModule_noCodeModule (13.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	14.235s
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]

Screenshots

Screenshot 2022-10-26 at 13 58 51

@miguelhrocha miguelhrocha changed the title create and update no-code module 🚧 [WIP] 🚧 create and update no-code module Oct 26, 2022
@miguelhrocha miguelhrocha changed the title 🚧 [WIP] 🚧 create and update no-code module Introduce no-code modules in registry modules Nov 15, 2022
@miguelhrocha miguelhrocha marked this pull request as ready for review November 15, 2022 19:42
@miguelhrocha miguelhrocha requested a review from a team as a code owner November 15, 2022 19:42
sebasslash
sebasslash requested changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there 😄 👍 -- Some blocking feedback below ⬇️

tfe/resource_tfe_registry_module.go Outdated Show resolved Hide resolved
tfe/resource_tfe_registry_module.go Outdated Show resolved Hide resolved
tfe/resource_tfe_registry_module_test.go Outdated Show resolved Hide resolved
website/docs/r/registry_module.html.markdown Outdated Show resolved Hide resolved
sebasslash
sebasslash approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've smoked tested ✔️ and behaves as expected. Requested changes have also been addressed 👍

@miguelhrocha miguelhrocha merged commit 8fc8adb into main Nov 18, 2022
@miguelhrocha miguelhrocha deleted the miguelhrocha/no-code-modules-attribute branch November 18, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasslash sebasslash sebasslash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miguelhrocha @sebasslash