Add support for fetching organization membership by username #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasslash
force-pushed
the
user-email-search-orgmemberships
branch
3 times, most recently
from
86f4350
to
4f780b0
Compare
sebasslash
force-pushed
the
user-email-search-orgmemberships
branch
3 times, most recently
from
72628ac
to
992492f
Compare
brandonc
requested changes
Oct 19, 2022
There was a problem hiding this comment.
My only blocking feedback is that we should populate username in the state, even when reading using email. My rationale is that this data source reuses resourceTFEOrganizationMembershipRead and that is the behavior of email when fetching by username.
That may mean adding username to the resource schema, which creates a nice symmetry and is free because we already include user data.
sebasslash
force-pushed
the
user-email-search-orgmemberships
branch
from
992492f
to
996b119
Compare
sebasslash
force-pushed
the
user-email-search-orgmemberships
branch
from
996b119
to
e984771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new attribute
usernametod/tfe_organization_membership, which allows for org memberships to be query-able by username.emailis no longer a required attribute and it is now marked as optional given you can supply a name or email. While we don't enforce that one or the other be defined at the schema level, the provider will error if both are not defined or"".This is a WIP as these changes rely on a unreleased changes to go-tfe, see related pull request.This PR also adds the same attribute
usernameas a computed property tor/tfe_organization_membership.