Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow agent pools to be imported by name #561

Merged
merged 4 commits into from Aug 2, 2022
Merged

Allow agent pools to be imported by name #561

merged 4 commits into from Aug 2, 2022

Conversation

JarrettSpiker
Copy link
Contributor

Description

Allow agent pools to be imported by org name/agent pool name

Testing plan

  1. Check that agent pool data sources still works
  2. Check that agent pools can still be imported by ID
    1. Check that agent pools can be imported by org/name
  4. Check that invalid import ID formats fail (eg a/b/c)
  5. Check for error if org name is not found
  6. Check for error if pool name is not found

External links

Output from acceptance tests

❯ go test github.com/hashicorp/terraform-provider-tfe/tfe  -run TestAccTFEAgentPool_import -v
=== RUN   TestAccTFEAgentPool_import
--- PASS: TestAccTFEAgentPool_import (104.15s)
PASS
ok
...

@JarrettSpiker JarrettSpiker requested a review from a team as a code owner July 20, 2022 21:34
SwiftEngineer
SwiftEngineer reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@SwiftEngineer SwiftEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about a case that may or may not deserve some additional handling, other than that this looks great! 🎉

tfe/resource_tfe_agent_pool.go Show resolved Hide resolved
sebasslash
sebasslash requested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 ! Minor grammatical error and a non blocker below ⬇️

tfe/agent_pool_helpers.go Outdated Show resolved Hide resolved
tfe/resource_tfe_agent_pool.go Show resolved Hide resolved
tfe/agent_pool_helpers.go Outdated Show resolved Hide resolved
@JarrettSpiker @sebasslash
Simplify error formatting for unfound agent pool
e03a0ca 
Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>
@JarrettSpiker @sebasslash
Fix typo in fetchAgentPoolID function name
9790800 
Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>
brandonc
brandonc approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it worked!

@JarrettSpiker JarrettSpiker merged commit 08c9a7d into main Aug 2, 2022
@JarrettSpiker JarrettSpiker deleted the jspiker/import-pool-by-name branch August 2, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwiftEngineer SwiftEngineer SwiftEngineer left review comments

@brandonc brandonc brandonc approved these changes

@sebasslash sebasslash sebasslash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JarrettSpiker @brandonc @sebasslash @SwiftEngineer