Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace run task stage property #555

Merged
merged 1 commit into from Aug 18, 2022
Merged

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Jul 19, 2022

Description

This commit adds the stage attribute to the Workspace Run Task
Resource and Data Source. Note that this is in beta for the
Resource. This commit adds acceptance tests, and optionally
test the Beta features.

This commit also adds descriptions for the Workspace Run Task
attributes.

Testing plan

  1. Acceptance tests cover the testing plan. Beta features require a feature flag to be enabled on TFC.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

With beta tests enabled

?       github.com/hashicorp/terraform-provider-tfe     [no test files]
=== RUN   TestAccTFEWorkspaceRunTask_create
--- PASS: TestAccTFEWorkspaceRunTask_create (38.84s)
=== RUN   TestAccTFEWorkspaceRunTask_beta_create
--- PASS: TestAccTFEWorkspaceRunTask_beta_create (34.31s)
=== RUN   TestAccTFEWorkspaceRunTask_import
--- PASS: TestAccTFEWorkspaceRunTask_import (27.11s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/tfe 100.750s
?       github.com/hashicorp/terraform-provider-tfe/version     [no test files]

@glennsarti glennsarti self-assigned this Jul 19, 2022
@glennsarti glennsarti marked this pull request as ready for review August 11, 2022 02:41
@glennsarti glennsarti requested a review from a team as a code owner August 11, 2022 02:41
Copy link
Member

@cam-stitt cam-stitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Would like someone from the CLI team to cover this also.

@glennsarti
Copy link
Contributor Author

Rebased due to changelog merge conflict

Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The only problem is that we released 0.36.0 and now the CHANGELOG needs to be moved to a new ## Unreleased section.

I also would hesitate to merge this unless it was available to customers. Can it wait until GA or is there some reason to publish this early?

@glennsarti
Copy link
Contributor Author

I also would hesitate to merge this unless it was available to customers.

It is available in TFC for everyone, but are you worried about TFE?

This commit adds the stage attribute to the Workspace Run Task
Resource and Data Source. Note that this is in beta for the
Resource.  This commit adds acceptance tests, and optionally
test the Beta features.

This commit also adds descriptions for the Workspace Run Task
attributes.
@glennsarti
Copy link
Contributor Author

Fixed the changelog

@brandonc
Copy link
Collaborator

@glennsarti nope- I didn't realize the flag had been enabled for customers.

@brandonc brandonc merged commit 1fc3e38 into main Aug 18, 2022
@brandonc brandonc deleted the gs/add-pre-plan-changes branch August 18, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants