New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workspace run task stage property #555
Conversation
cf34360
to
d2831b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Would like someone from the CLI team to cover this also.
d2831b5
to
080f778
Compare
Rebased due to changelog merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. The only problem is that we released 0.36.0 and now the CHANGELOG needs to be moved to a new ## Unreleased section.
I also would hesitate to merge this unless it was available to customers. Can it wait until GA or is there some reason to publish this early?
It is available in TFC for everyone, but are you worried about TFE? |
This commit adds the stage attribute to the Workspace Run Task Resource and Data Source. Note that this is in beta for the Resource. This commit adds acceptance tests, and optionally test the Beta features. This commit also adds descriptions for the Workspace Run Task attributes.
080f778
to
f3754e3
Compare
Fixed the changelog |
@glennsarti nope- I didn't realize the flag had been enabled for customers. |
Description
This commit adds the stage attribute to the Workspace Run Task
Resource and Data Source. Note that this is in beta for the
Resource. This commit adds acceptance tests, and optionally
test the Beta features.
This commit also adds descriptions for the Workspace Run Task
attributes.
Testing plan
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
With beta tests enabled