Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for managing health assessment (drift detection) settings on workspaces and organizations #550

Merged
merged 16 commits into from Sep 26, 2022

Conversation

rexredinger
Copy link
Contributor

Description

This Change is to allow operators to manage the drift detection setting for workspaces.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace_basicDriftDetection" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEWorkspace_basicDriftDetection -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFEWorkspace_basicDriftDetection
--- PASS: TestAccTFEWorkspace_basicDriftDetection (11.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	11.978s
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]
...
$ TESTARGS="-run TestAccTFEWorkspaceDataSource_basic" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEWorkspaceDataSource_basic -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFEWorkspaceDataSource_basic
--- PASS: TestAccTFEWorkspaceDataSource_basic (6.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	6.667s
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]

@rexredinger rexredinger added enhancement feature-flag Features that sit behind a feature flag labels Jul 14, 2022
@annawinkler annawinkler changed the title Add support for managing srift detection setting on workspaces Add support for managing drift detection setting on workspaces Jul 20, 2022
@rexredinger rexredinger requested a review from a team as a code owner September 7, 2022 12:33
@rexredinger rexredinger changed the title Add support for managing drift detection setting on workspaces Add support for managing health assessment (drift detection) settings on workspaces and organizations Sep 7, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this PR! I smoke tested this PR with the go-tfe PR and things look good. I found one issue that needs to be fixed to test (see the comment), and then there are a few minor suggestions I have.

@rexredinger rexredinger force-pushed the support-workspace-drift-detection branch from da8c579 to 4ee58ff Compare September 15, 2022 17:16
Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! I smoke tested with organization and workspace data sources and resources, and everything is working as expected.

Could you update the data source and resource docs for organization to include the new attribute? And then I think we're good to :shipit: 🥳

rexredinger and others added 4 commits September 26, 2022 16:39
Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 :shipit:

Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
@rexredinger rexredinger merged commit 833606a into main Sep 26, 2022
@rexredinger rexredinger deleted the support-workspace-drift-detection branch September 26, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature-flag Features that sit behind a feature flag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants