Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Teams destination to notification_configuration #484

Merged
merged 5 commits into from Jun 15, 2022

Conversation

JarrettSpiker
Copy link
Contributor

@JarrettSpiker JarrettSpiker commented May 3, 2022

Description

Adds microsoft_teams as a valid destination for a notification_configuration

The Microsoft Teams notification config will be the same as the Slack notification config, so this is mostly a copy of the Slack notification implementation and tests

Blocked on:

Testing plan

  1. Check that the tfe provider can create, update, and destroy notification configurations for MS Teams
  2. Check that notification config resources tar-getting microsoft teams are correctly validated (same requirements as the Slack config)

External links

Output from acceptance tests

❯ go test github.com/hashicorp/terraform-provider-tfe/tfe -run TestAccTFENotificationConfiguration_ -v
=== RUN   TestAccTFENotificationConfiguration_basic
--- PASS: TestAccTFENotificationConfiguration_basic (9.45s)
=== RUN   TestAccTFENotificationConfiguration_emailUserIDs
--- PASS: TestAccTFENotificationConfiguration_emailUserIDs (9.37s)
=== RUN   TestAccTFENotificationConfiguration_updateEmailUserIDs
--- PASS: TestAccTFENotificationConfiguration_updateEmailUserIDs (15.07s)
=== RUN   TestAccTFENotificationConfiguration_validateSchemaAttributesEmail
--- PASS: TestAccTFENotificationConfiguration_validateSchemaAttributesEmail (7.16s)
=== RUN   TestAccTFENotificationConfiguration_validateSchemaAttributesGeneric
--- PASS: TestAccTFENotificationConfiguration_validateSchemaAttributesGeneric (10.43s)
=== RUN   TestAccTFENotificationConfiguration_validateSchemaAttributesSlack
--- PASS: TestAccTFENotificationConfiguration_validateSchemaAttributesSlack (12.41s)
=== RUN   TestAccTFENotificationConfiguration_validateSchemaAttributesMicrosoftTeams
--- PASS: TestAccTFENotificationConfiguration_validateSchemaAttributesMicrosoftTeams (12.40s)
=== RUN   TestAccTFENotificationConfiguration_updateValidateSchemaAttributesEmail
--- PASS: TestAccTFENotificationConfiguration_updateValidateSchemaAttributesEmail (14.11s)
=== RUN   TestAccTFENotificationConfiguration_updateValidateSchemaAttributesGeneric
--- PASS: TestAccTFENotificationConfiguration_updateValidateSchemaAttributesGeneric (16.93s)
=== RUN   TestAccTFENotificationConfiguration_updateValidateSchemaAttributesSlack
--- PASS: TestAccTFENotificationConfiguration_updateValidateSchemaAttributesSlack (20.29s)
=== RUN   TestAccTFENotificationConfiguration_updateValidateSchemaAttributesMicrosoftTeams
--- PASS: TestAccTFENotificationConfiguration_updateValidateSchemaAttributesMicrosoftTeams (18.76s)
=== RUN   TestAccTFENotificationConfiguration_duplicateTriggers
--- PASS: TestAccTFENotificationConfiguration_duplicateTriggers (8.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	155.139s...

go.mod Outdated
@@ -13,7 +13,7 @@ require (
github.com/hashicorp/go-multierror v1.1.1 // indirect
github.com/hashicorp/go-retryablehttp v0.7.1 // indirect
github.com/hashicorp/go-slug v0.8.1
github.com/hashicorp/go-tfe v1.2.0
github.com/hashicorp/go-tfe v1.2.1-0.20220607193402-515f37b540ef

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be updated or is this version tag correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what was holding this up! I was waiting on the 1.3.0 release

@mpminardi
Copy link

This is looking good to me aside from the question about the go-tfe version

@JarrettSpiker JarrettSpiker merged commit a5f8efe into main Jun 15, 2022
@JarrettSpiker JarrettSpiker deleted the jspiker/ms-teams branch June 15, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants