Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated project name limit from 36 to 40 characters #1351

Conversation

hs26gill
Copy link
Contributor

@hs26gill hs26gill commented May 8, 2024

Description

This PR increases the project name character length from 36 to 40 character.

Remember to:

Testing plan

Covered by integration tests

External links

@hs26gill hs26gill requested a review from a team as a code owner May 8, 2024 16:38
@hs26gill hs26gill force-pushed the hs26gill/TF-15236-Provider-Increase-Project-Name-char-limit-to-40-characters branch from dd51831 to 8fd6bf9 Compare May 8, 2024 16:46
@hs26gill hs26gill force-pushed the hs26gill/TF-15236-Provider-Increase-Project-Name-char-limit-to-40-characters branch from 8fd6bf9 to b5d0aff Compare May 21, 2024 15:42
@hs26gill
Copy link
Contributor Author

Tested resource changes locally and tested data source tests as well

resource_tfe_project_test.go ✅

/opt/homebrew/Cellar/go/1.22.2/libexec/bin/go tool test2json -t /private/var/folders/1t/7pbj37tx1x7fjjnvcxkwj7b80000gq/T/GoLand/___resource_tfe_project_test_go.test -test.v -test.paniconexit0 -test.run ^\QTestAccTFEProject_basic\E|\QTestAccTFEProject_invalidName\E|\QTestAccTFEProject_update\E|\QTestAccTFEProject_import\E$
=== RUN   TestAccTFEProject_basic
--- PASS: TestAccTFEProject_basic (6.50s)
=== RUN   TestAccTFEProject_invalidName
--- PASS: TestAccTFEProject_invalidName (0.17s)
=== RUN   TestAccTFEProject_update
--- PASS: TestAccTFEProject_update (8.30s)
=== RUN   TestAccTFEProject_import
--- PASS: TestAccTFEProject_import (6.60s)
PASS

data_source_project_test.go ✅

/opt/homebrew/Cellar/go/1.22.2/libexec/bin/go tool test2json -t /private/var/folders/1t/7pbj37tx1x7fjjnvcxkwj7b80000gq/T/GoLand/___data_source_project_test_go.test -test.v -test.paniconexit0 -test.run ^\QTestAccTFEProjectDataSource_basic\E|\QTestAccTFEProjectDataSource_caseInsensitive\E$
=== RUN   TestAccTFEProjectDataSource_basic
--- PASS: TestAccTFEProjectDataSource_basic (10.57s)
=== RUN   TestAccTFEProjectDataSource_caseInsensitive
--- PASS: TestAccTFEProjectDataSource_caseInsensitive (7.32s)
PASS

@hs26gill hs26gill merged commit 1d447dd into main May 21, 2024
6 checks passed
@hs26gill hs26gill deleted the hs26gill/TF-15236-Provider-Increase-Project-Name-char-limit-to-40-characters branch May 21, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants