Add Bitbucket Data Center support

[zainq11]

Description

On Feb 15, 2024, Atlassian stopped support for Bitbucket Server. This PR introduces changes in go-tfe so that we can support Bitbucket Data Center while keeping Bitbucket Server. The docs, tests and examples have been updated to reference Bitbucket Data Center instead of Bitbucket Server to align with the deprecation of server.

Remember to:

• Update the Change Log
• Update the Documentation

Testing plan

1. Running CI
2. local testing with updated terraform provider creates a bitbucket data center vcs connection.

resource "tfe_oauth_client" "test" {
  name = "bbdc-cli-tester"
  # organization     = "zain-tfe"
  api_url          = "https://bitbucket.dev.tf-vcs.hashicorp.services"
  http_url         = "https://bitbucket.dev.tf-vcs.hashicorp.services"
  key              = "my_key"
  secret           = "-----BEGIN RSA PRIVATE KEY-----XXXXX-----END RSA PRIVATE KEY-----\n"
  rsa_public_key   = "-----BEGIN PUBLIC KEY-----XXXXX-----END PUBLIC KEY-----\n"
  service_provider = "bitbucket_data_center"
}

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

• go-tfe documentation
• go-tfe PR

Output from acceptance tests

Successfully ran all tests in resource_tfe_oauth_client_test.go

❯ TESTARGS="-run TFEOAuthClient" TEST="./internal/provider" make testacc

TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test ./internal/provider -v -run TFEOAuthClient -timeout 15m
=== RUN   TestAccTFEOAuthClientDataSource_basic
--- PASS: TestAccTFEOAuthClientDataSource_basic (4.98s)
=== RUN   TestAccTFEOAuthClientDataSource_findByID
--- PASS: TestAccTFEOAuthClientDataSource_findByID (3.28s)
=== RUN   TestAccTFEOAuthClientDataSource_findByName
--- PASS: TestAccTFEOAuthClientDataSource_findByName (3.34s)
=== RUN   TestAccTFEOAuthClientDataSource_findByServiceProvider
--- PASS: TestAccTFEOAuthClientDataSource_findByServiceProvider (3.10s)
=== RUN   TestAccTFEOAuthClientDataSource_missingParameters
--- PASS: TestAccTFEOAuthClientDataSource_missingParameters (0.13s)
=== RUN   TestAccTFEOAuthClientDataSource_missingOrgWithName
--- PASS: TestAccTFEOAuthClientDataSource_missingOrgWithName (0.13s)
=== RUN   TestAccTFEOAuthClientDataSource_missingOrgWithServiceProvider
--- PASS: TestAccTFEOAuthClientDataSource_missingOrgWithServiceProvider (0.12s)
=== RUN   TestAccTFEOAuthClientDataSource_sameName
--- PASS: TestAccTFEOAuthClientDataSource_sameName (2.34s)
=== RUN   TestAccTFEOAuthClientDataSource_noName
--- PASS: TestAccTFEOAuthClientDataSource_noName (1.94s)
=== RUN   TestAccTFEOAuthClientDataSource_sameServiceProvider
--- PASS: TestAccTFEOAuthClientDataSource_sameServiceProvider (2.37s)
=== RUN   TestAccTFEOAuthClient_basic
--- PASS: TestAccTFEOAuthClient_basic (2.75s)
=== RUN   TestAccTFEOAuthClientWithOrganizationScoped_basic
--- PASS: TestAccTFEOAuthClientWithOrganizationScoped_basic (2.52s)
=== RUN   TestAccTFEOAuthClient_rsaKeys
--- PASS: TestAccTFEOAuthClient_rsaKeys (2.71s)
PASS

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

[laurenolivia]

@zainq11 ping me if you need another review

[zainq11]

@zainq11 ping me if you need another review

@laurenolivia Could you please review when you have time. I have made changes to the CHANGELOG.md and as discussed in slack, I have also run tests in resource_tfe_oauth_client_test.go which touch the updated resource. Please let me know if there is anything else I need to test as well. Happy to do that!

❯ TESTARGS="-run TFEOAuthClient" TEST="./internal/provider" make testacc

TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test ./internal/provider -v -run TFEOAuthClient -timeout 15m
=== RUN   TestAccTFEOAuthClientDataSource_basic
--- PASS: TestAccTFEOAuthClientDataSource_basic (4.98s)
=== RUN   TestAccTFEOAuthClientDataSource_findByID
--- PASS: TestAccTFEOAuthClientDataSource_findByID (3.28s)
=== RUN   TestAccTFEOAuthClientDataSource_findByName
--- PASS: TestAccTFEOAuthClientDataSource_findByName (3.34s)
=== RUN   TestAccTFEOAuthClientDataSource_findByServiceProvider
--- PASS: TestAccTFEOAuthClientDataSource_findByServiceProvider (3.10s)
=== RUN   TestAccTFEOAuthClientDataSource_missingParameters
--- PASS: TestAccTFEOAuthClientDataSource_missingParameters (0.13s)
=== RUN   TestAccTFEOAuthClientDataSource_missingOrgWithName
--- PASS: TestAccTFEOAuthClientDataSource_missingOrgWithName (0.13s)
=== RUN   TestAccTFEOAuthClientDataSource_missingOrgWithServiceProvider
--- PASS: TestAccTFEOAuthClientDataSource_missingOrgWithServiceProvider (0.12s)
=== RUN   TestAccTFEOAuthClientDataSource_sameName
--- PASS: TestAccTFEOAuthClientDataSource_sameName (2.34s)
=== RUN   TestAccTFEOAuthClientDataSource_noName
--- PASS: TestAccTFEOAuthClientDataSource_noName (1.94s)
=== RUN   TestAccTFEOAuthClientDataSource_sameServiceProvider
--- PASS: TestAccTFEOAuthClientDataSource_sameServiceProvider (2.37s)
=== RUN   TestAccTFEOAuthClient_basic
--- PASS: TestAccTFEOAuthClient_basic (2.75s)
=== RUN   TestAccTFEOAuthClientWithOrganizationScoped_basic
--- PASS: TestAccTFEOAuthClientWithOrganizationScoped_basic (2.52s)
=== RUN   TestAccTFEOAuthClient_rsaKeys
--- PASS: TestAccTFEOAuthClient_rsaKeys (2.71s)
PASS

[brandonc]

Good job balancing docs and deprecation without breaking anything