Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cloudfunction firestore test #18141

Closed
wants to merge 1 commit into from
Closed

Conversation

dixuswe
Copy link

@dixuswe dixuswe commented May 15, 2024

fixes #18072

Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from melinath May 15, 2024 05:58
Copy link
Collaborator

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


resource "google_firestore_database" "database" {
project = data.google_project.project.project_id
name = "(default)"
Copy link
Collaborator

@melinath melinath May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use a custom database name rather than default, then reference this database from the function? Or does the function always use the default database? (If it always uses the default database then we'd need a different solution for ensuring this is set up.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCFv1 only support (default) firestore database trigger

@dixuswe dixuswe closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudFunctionsFunction_firestore
2 participants