Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Managed Service for Prometheus #4105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbarrien
Copy link
Contributor

@mbarrien mbarrien commented Mar 5, 2022

Adds support for Managed Service for Prometheus to google_container_cluster. Closes hashicorp/terraform-provider-google#11224

Configuration looks like the following:

resource "google_container_cluster" {
  monitoring_config {
    managed_prometheus {
      enabled = true
    }
  }
}

Open Issues:

  • To do this, makes monitoring_config.enabled_components into an optional, to allow configuring just the managed Prometheus component. Without further tests (that might require me to spin up an actual cluster), it's unclear if leaving that empty when enabling just the Prometheus component does the right thing.
  • Unclear whether I need to add a ForceSendFields = ["Enabled"] to ensure that prometheus is properly disabled if the component is removed.

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind making this against https://github.com/GoogleCloudPlatform/magic-modules? Thanks!

Sorry, there's some docs that need to be updated to point there exclusively, rather than as an option- at one point the environments were pretty much equivalent, but on-PR CI is substantially better there nowadays.

Any files you edited will have a counterpart in https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform, so it's just a matter of replaying the changes.

@NeckBeardPrince
Copy link

Hasn't this been completed a long time ago? We can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants