Add rate limit options to google_compute_security_policy
#3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megan07
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
Hi @anovis ! Thank you for your contribution and sorry for the delay in review! The majority of our PRs are open in our upstream repo where they are automatically assigned reviewers, this was mistakenly overlooked. I left one comment, feel free to make those changes in the upstream file and it will make it easier for us to run tests and review!
| @@ -311,6 +397,9 @@ func resourceComputeSecurityPolicyRead(d *schema.ResourceData, meta interface{}) | |||
| if err := d.Set("adaptive_protection_config", flattenSecurityPolicyAdaptiveProtectionConfig(securityPolicy.AdaptiveProtectionConfig)); err != nil { | |||
| return fmt.Errorf("Error setting adaptive_protection_config: %s", err) | |||
| } | |||
| if err := d.Set("rate_limit_options", flattenSecurityPolicyRateLimitOptions(securityPolicy.RateLimitOptions)); err != nil { | |||
There was a problem hiding this comment.
I think we're going to want to move all of this logic inside the flattenSecurityPolicyRules logic, since it is nested inside the rule. That being said, I think the type we're looking for here is called SecurityPolicyRuleRateLimitOptions.
5 tasks
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#10020
similar to hashicorp/terraform-provider-google#8984
todo:
do i need to add a pr to the main google repo to add the compute structs for
RateLimitOptions?