Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable rbac for data_fusion_instance #3221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Guimove
Copy link

@Guimove Guimove commented May 4, 2021

Google as recently enabled an RBAC option for Data fusion instance. We want to use it on a big project to share an instance with multiple tenants.
So I'm happy to add my magic sauce to make it work.

Hope all is ok.

Fix hashicorp/terraform-provider-google#9065

@ghost ghost added size/xs labels May 4, 2021
@ghost ghost requested review from slevenick May 4, 2021 09:23
@ghost ghost added size/s and removed size/xs labels May 4, 2021
@slevenick
Copy link
Collaborator

Hmmmm, do you have a link to where this was announced? I can't find this field on the API docs: https://cloud.google.com/data-fusion/docs/reference/rest/v1beta1/projects.locations.instances#Instance

We use a code generator (https://github.com/GoogleCloudPlatform/magic-modules) to generate this file, so the change will need to be made there. It should be fairly simple assuming this field is publicly available. I can help with that change as well

@Guimove
Copy link
Author

Guimove commented May 4, 2021

My bad, it seems it was not announced, seems we are in a preview.
But as we are doing everything with terraform, we are actually blocked.

Do you think we can continue to work on this or wait for public announcement ?
It's already present in the GO client, for example https://github.com/googleapis/google-api-go-client/blob/9c02ff42de049ba27fb380e5660276ecbe0315a2/datafusion/v1beta1/datafusion-api.json#L959

I'll check tomorrow for the magic module.

Thanks,

@slevenick
Copy link
Collaborator

I'll ask around

@Guimove
Copy link
Author

Guimove commented May 21, 2021

Hey, do you have any feedback ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants