Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_web_pubsub_custom_certificate - added time delay to avoid 409 error #25829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

azurerm_web_pubsub_custom_certificate - added time delay to avoid 409 error #25829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/services/signalr/web_pubsub_custom_certificate_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ func (r CustomCertWebPubsubResource) Create() sdk.ResourceFunc {

}

time.Sleep(30 * time.Second)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically do not add delays like this into the provider as they delay can range from shorter to longer, however as its a unique 409 status we could implement a retry. you can search the provider for pluginsdk.Retry and use that as an example.

thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katbyte, I will try that out.


if err := client.CustomCertificatesCreateOrUpdateThenPoll(ctx, id, customCertObj); err != nil {
return fmt.Errorf("creating web pubsub custom certificate: %s: %+v", id, err)
}
Expand Down