docs - awscc_cloudfront_distribution #977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wellsiau-aws
suggested changes
Jun 8, 2023
|
|
||
| {{ tffile (printf "examples/resources/%s/cloudfront_with_s3_origin_oai.tf" .Name)}} | ||
|
|
||
| ## NOTE: After successful resource creation, edit the Cloufront Origin, origin access from default public setting to use either the OAC or OAI which were created |
There was a problem hiding this comment.
this looks like a problem upstream on the handler , please open a Github issue
There was a problem hiding this comment.
Thanks - Issue logged - #983 (comment)
|
|
||
| {{ tffile (printf "examples/resources/%s/cloudfront_with_s3_origin_oai.tf" .Name)}} | ||
|
|
||
| ## NOTE: After successful resource creation, edit the Cloufront Origin, origin access from default public setting to use either the OAC or OAI which were created |
There was a problem hiding this comment.
please remove this note, we expect the issue to be resolved upstream and hold the merge until then
wellsiau-aws
suggested changes
Jun 12, 2023
There was a problem hiding this comment.
remove the note, and we'll hold up the merge until issue #983 is triaged
…solved upstream
|
Note added part of the documentation for workaround was removed and PR updated with changes. Awaiting resolution on Issue#983 before merging the PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000