Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added example for awscc_location_api_key #1722

Merged

Conversation

quixoticmonk
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

#1721 might be one of those cases where the required fields are based on types. Added example with a base case of noexpiry to show usage. Will keep tracking the issue.

@quixoticmonk quixoticmonk force-pushed the d-improve-awscc_location_api_key branch from f42fd8c to 9063e93 Compare May 18, 2024 02:54
Copy link

@jackywong-amazon jackywong-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosentino marcosentino merged commit ab64927 into hashicorp:main May 28, 2024
2 checks passed
@marcosentino
Copy link
Contributor

@quixoticmonk Thank you for the contribution!

@quixoticmonk quixoticmonk deleted the d-improve-awscc_location_api_key branch May 28, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants