Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Complete resource documentation for aws_bedrockagent_data_source #37452

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented May 12, 2024

Description

This PR is to complete the resource documentation for aws_bedrockagent_data_source.

Relations

Closes #37420

References

Referred to CreateDataSource for descriptions.

Output from Acceptance Testing

n/a

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels May 12, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 12, 2024
@acwwat acwwat force-pushed the d-aws_bedrockagent_data_source-complete_doc branch 3 times, most recently from 9cf0395 to f9b2c0c Compare May 12, 2024 17:54
@acwwat acwwat force-pushed the d-aws_bedrockagent_data_source-complete_doc branch from f9b2c0c to 1c3dcf8 Compare May 12, 2024 22:58
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 13, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e6bcb87 into hashicorp:main May 13, 2024
26 checks passed
@github-actions github-actions bot added this to the v5.50.0 milestone May 13, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the d-aws_bedrockagent_data_source-complete_doc branch May 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: aws_bedrockagent_data_source doc is rather empty
2 participants