Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweepers: Adds new registration and removes boilerplate #32291

Merged
merged 9 commits into from Oct 17, 2023
Merged

sweepers: Adds new registration and removes boilerplate #32291

merged 9 commits into from Oct 17, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jun 29, 2023 •
edited by ewbankkit

Description

Removes need for sweep build tags by calling new RegisterSweepers function from the sweeper.

Adds new sweep.Register which removes boilerplate and takes function that returns an array of Sweepables.

Adds GHA validation that sweeper functions are not exported in provider executable.

Relations

Relates #24165.
Closes #13516 (I think).

Dependencies

Depends on release of

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ecs Issues and PRs that pertain to the ecs service. service/emr Issues and PRs that pertain to the emr service. service/guardduty Issues and PRs that pertain to the guardduty service. service/configservice Issues and PRs that pertain to the configservice service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/dax Issues and PRs that pertain to the dax service. service/directconnect Issues and PRs that pertain to the directconnect service. service/codebuild Issues and PRs that pertain to the codebuild service. service/gamelift Issues and PRs that pertain to the gamelift service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/lightsail Issues and PRs that pertain to the lightsail service. service/acm Issues and PRs that pertain to the acm service. service/elb Issues and PRs that pertain to the elb service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/glacier Issues and PRs that pertain to the glacier service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/medialive Issues and PRs that pertain to the medialive service. service/athena Issues and PRs that pertain to the athena service. service/firehose Issues and PRs that pertain to the firehose service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/mq Issues and PRs that pertain to the mq service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. labels Jun 29, 2023
@github-actions github-actions bot added service/cur Issues and PRs that pertain to the cur service. service/evidently Issues and PRs that pertain to the evidently service. service/healthlake Issues and PRs that pertain to the healthlake service. service/fis Issues and PRs that pertain to the fis service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. labels Jun 29, 2023
@gdavison gdavison marked this pull request as draft June 30, 2023 19:43
@gdavison gdavison force-pushed the td-sweepers branch 2 times, most recently from 56fc61e to fb53d3c Compare September 29, 2023 05:49
@gdavison gdavison marked this pull request as ready for review September 29, 2023 05:49
ewbankkit
ewbankkit approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Needs merge conflicts to be resolved.

@gdavison gdavison merged commit c1efdd2 into main Oct 17, 2023
44 checks passed
@gdavison gdavison deleted the td-sweepers branch October 17, 2023 00:43
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 17, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appconfig Issues and PRs that pertain to the appconfig service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/athena Issues and PRs that pertain to the athena service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/budgets Issues and PRs that pertain to the budgets service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/cur Issues and PRs that pertain to the cur service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. service/firehose Issues and PRs that pertain to the firehose service. service/fis Issues and PRs that pertain to the fis service. service/fsx Issues and PRs that pertain to the fsx service. service/gamelift Issues and PRs that pertain to the gamelift service. service/glacier Issues and PRs that pertain to the glacier service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/grafana Issues and PRs that pertain to the grafana service. service/guardduty Issues and PRs that pertain to the guardduty service. service/healthlake Issues and PRs that pertain to the healthlake service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. service/iot Issues and PRs that pertain to the iot service. service/kafka Issues and PRs that pertain to the kafka service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/kendra Issues and PRs that pertain to the kendra service. service/keyspaces Issues and PRs that pertain to the keyspaces service. service/kinesis Issues and PRs that pertain to the kinesis service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/lightsail Issues and PRs that pertain to the lightsail service. service/location Issues and PRs that pertain to the location service. service/logs Issues and PRs that pertain to the logs service. service/medialive Issues and PRs that pertain to the medialive service. service/memorydb Issues and PRs that pertain to the memorydb service. service/mq Issues and PRs that pertain to the mq service. service/mwaa Issues and PRs that pertain to the mwaa service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @ewbankkit