Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Remove external provider aliases #27815

Merged
merged 3 commits into from Nov 15, 2022

Conversation

ewbankkit
Copy link
Contributor

Description

hashicorp/terraform-plugin-sdk#1092 removes the need to use external provider aliases in acceptance test configurations.

Relations

Relates #27499.
Relates #27615.
Relates #27803.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEMRContainersVirtualCluster_basic' PKG=emrcontainers
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emrcontainers/... -v -count 1 -parallel 20  -run=TestAccEMRContainersVirtualCluster_basic -timeout 180m
=== RUN   TestAccEMRContainersVirtualCluster_basic
=== PAUSE TestAccEMRContainersVirtualCluster_basic
=== CONT  TestAccEMRContainersVirtualCluster_basic
--- PASS: TestAccEMRContainersVirtualCluster_basic (1209.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	1216.440s
% make testacc TESTARGS='-run=TestAccBatchComputeEnvironment_eksConfiguration' PKG=batch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20  -run=TestAccBatchComputeEnvironment_eksConfiguration -timeout 180m
=== RUN   TestAccBatchComputeEnvironment_eksConfiguration
=== PAUSE TestAccBatchComputeEnvironment_eksConfiguration
=== CONT  TestAccBatchComputeEnvironment_eksConfiguration
--- PASS: TestAccBatchComputeEnvironment_eksConfiguration (778.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	783.646s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Nov 15, 2022
@ewbankkit ewbankkit merged commit 29e0a16 into main Nov 15, 2022
@ewbankkit ewbankkit deleted the t-remove-external-provider-aliases branch November 15, 2022 14:58
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
github-actions bot pushed a commit that referenced this pull request Nov 15, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/batch Issues and PRs that pertain to the batch service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant