Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates actions/setup-go to use go-version-file #25089

Merged
merged 1 commit into from Jun 6, 2022
Merged

Updates actions/setup-go to use go-version-file #25089

merged 1 commit into from Jun 6, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 27, 2022 •
edited by anGie44

Closes #24937

Now that actions/setup-go#62 has been merged, the GitHub action setup-go can now read the Go version from the .go-version file. Update uses of the setup-go action to use this feature.

Output from acceptance testing:

N/A

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/M Managed by automation to categorize the size of a PR. labels May 27, 2022
ewbankkit
ewbankkit approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

I've seen other projects in the ecosystem (e.g. hashicorp/terraform-plugin-sdk#974) use go.mod instead of .go-version. Any thoughts on that approach?

@gdavison
Copy link
Contributor Author

gdavison commented Jun 6, 2022

go.mod and .go-version have different meanings: go.mod is a version compatibility statement, whereas .go-version specifies a specific version.

@gdavison gdavison merged commit 1c2747f into main Jun 6, 2022
@gdavison gdavison deleted the update-setup-go-config branch June 6, 2022 18:33
@github-actions github-actions bot added this to the v4.18.0 milestone Jun 6, 2022
@github-actions
Copy link

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.18.0
Development

Successfully merging this pull request may close these issues.

Migrate github actions workflows to use actions/setup-go go-version-file input
2 participants
@gdavison @ewbankkit