Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: reinstate goreleaser check and build for a single 32-bit arch #24938

Merged
merged 1 commit into from May 24, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8988
Relates #24937
Relates #24890

Output from goreleaser is using the 614939c commit for testing:

$ goreleaser build --config .github/goreleaser-cross-compiler-test.yml --id 32-bit-arch --snapshot --rm-dist
   • building...
   • loading config file       file=.github/goreleaser-cross-compiler-test.yml
   • single build in config, '--id' ignored
   • loading environment variables
   • getting and validating git state
      • building...               commit=614939c70bfa212bc105cf0b9f4e8762fbd431a1 latest tag=v4.14.0
      • pipe skipped              error=disabled during snapshot mode
   • parsing tag
   • running before hooks
      • running                   hook=go mod download
   • setting defaults
   • snapshotting
      • building snapshot...      version=v4.14.0-next
   • checking distribution directory
      • --rm-dist is set, cleaning it up
   • loading go mod information
   • build prerequisites
   • writing effective config file
      • writing                   config=dist/config.yaml
   • building binaries
      • building                  binary=dist/32-bit-arch_freebsd_arm_6/terraform-provider-aws_vv4.14.0-next_x5
   ⨯ build failed after 4.58s error=failed to build for freebsd_arm_6: exit status 2: # github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager
internal/service/networkmanager/core_network_policy_document_data_source.go:167:34: cannot use 4200000000 (untyped int constant) as int value in argument to validation.IntBetween (overflows)
internal/service/networkmanager/core_network_policy_document_data_source.go:167:46: cannot use 4294967294 (untyped int constant) as int value in argument to validation.IntBetween (overflows)

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels May 23, 2022
@anGie44 anGie44 marked this pull request as ready for review May 23, 2022 16:45
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 force-pushed the gha-terraform-provider-worfklow-reinstate-arch-build branch from dd2f769 to 91310a8 Compare May 24, 2022 23:31
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed linter Pertains to changes to or issues with the various linters. size/S Managed by automation to categorize the size of a PR. labels May 24, 2022
@anGie44 anGie44 force-pushed the gha-terraform-provider-worfklow-reinstate-arch-build branch from 91310a8 to d31a389 Compare May 24, 2022 23:33
@anGie44 anGie44 force-pushed the gha-terraform-provider-worfklow-reinstate-arch-build branch from d31a389 to 9ee2bd9 Compare May 24, 2022 23:42
@anGie44 anGie44 added this to the v4.16.0 milestone May 24, 2022
@anGie44 anGie44 merged commit e6725b7 into main May 24, 2022
@anGie44 anGie44 deleted the gha-terraform-provider-worfklow-reinstate-arch-build branch May 24, 2022 23:53
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants