Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final sweeper error to logs #983

Merged
merged 3 commits into from Jun 15, 2022
Merged

Add final sweeper error to logs #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8e6805
Adds final sweeper error to logs
gdavison Jun 14, 2022
ace6f6a
Moves logging to prevent double log on API call errors
gdavison Jun 14, 2022
08d46aa
Adds CHANGELOG entry
gdavison Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/983.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
helper/resource: Ensured errors are always logged.
```
1 change: 1 addition & 0 deletions helper/resource/testing.go
View file
Open in desktop
Expand Up @@ -237,6 +237,7 @@ func runSweeperWithRegion(region string, s *Sweeper, sweepers map[string]*Sweepe
depSweeper, ok := sweepers[dep]

if !ok {
log.Printf("[ERROR] Sweeper (%s) has dependency (%s), but that sweeper was not found", s.Name, dep)
return fmt.Errorf("sweeper (%s) has dependency (%s), but that sweeper was not found", s.Name, dep)
}

Expand Down