Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/logging: Ensure @caller in SDK subsystem logging entries accurately reflects calling code location #939

Merged
merged 4 commits into from Apr 14, 2022
Merged

internal/logging: Ensure @caller in SDK subsystem logging entries accurately reflects calling code location #939

merged 4 commits into from Apr 14, 2022

Commits on Apr 12, 2022

  1. internal/logging: Ensure @caller in SDK subsystem logging entries a… 

    …ccurately reflects calling code location

Reference: hashicorp/terraform-plugin-go#179

Previously:

```
2022-04-12T11:11:26.086-0400 [TRACE] provider.terraform-provider-aws: Found data source type: @caller=/Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/internal/logging/helper_schema.go:21 @module=sdk.helper_schema tf_data_source_type=aws_connect_bot_association timestamp=2022-04-12T11:11:25.917-0400
2022-04-12T11:11:26.086-0400 [TRACE] provider.terraform-provider-aws: Found data source type: @caller=/Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/internal/logging/helper_schema.go:21 @module=sdk.helper_schema tf_data_source_type=aws_datapipeline_pipeline timestamp=2022-04-12T11:11:25.917-0400
```

Now:

```
2022-04-12T14:54:22.571-0400 [TRACE] provider.terraform-provider-aws: Found data source type: @module=sdk.helper_schema tf_data_source_type=aws_connect_bot_association @caller=/Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/schema/grpc_provider.go:95 timestamp=2022-04-12T14:54:22.571-0400
2022-04-12T14:54:22.574-0400 [TRACE] provider.terraform-provider-aws: Found data source type: @module=sdk.helper_schema tf_data_source_type=aws_datapipeline_pipeline @caller=/Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/schema/grpc_provider.go:95 timestamp=2022-04-12T14:54:22.574-0400
```
    @bflad
    bflad committed Apr 12, 2022
    Copy the full SHA
    84d71d0 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #939

    @bflad
    bflad committed Apr 12, 2022
    Copy the full SHA
    4f53cb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Ivan De Marino <ivan.demarino@hashicorp.com>
    @bflad
    bflad and Ivan De Marino committed Apr 14, 2022
    Copy the full SHA
    732c73b View commit details
    Browse the repository at this point in the history

  2. Update internal/logging/context.go

    @bflad
    bflad committed Apr 14, 2022
    Copy the full SHA
    9bd6114 View commit details
    Browse the repository at this point in the history