Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Expected Minimum Go Version to 1.17 #934

Merged
merged 2 commits into from Apr 12, 2022
Merged

Bump Expected Minimum Go Version to 1.17 #934

merged 2 commits into from Apr 12, 2022

Commits on Apr 11, 2022

  1. Bump Expected Minimum Go Version to 1.17

    Reference: #933
    
    Previously from `tenv` linter:
    
    ```
    helper/schema/schema_test.go:29:2: os.Setenv() can be replaced by `t.Setenv()` in TestEnvDefaultFunc (tenv)
            if err := os.Setenv(key, "foo"); err != nil {
            ^
    helper/schema/schema_test.go:67:2: os.Setenv() can be replaced by `t.Setenv()` in TestMultiEnvDefaultFunc (tenv)
            if err := os.Setenv(keys[0], "foo"); err != nil {
            ^
    helper/schema/schema_test.go:85:2: os.Setenv() can be replaced by `t.Setenv()` in TestMultiEnvDefaultFunc (tenv)
            if err := os.Setenv(keys[1], "foo"); err != nil {
            ^
    helper/schema/schema_test.go:8479:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorDefaultsFalse (tenv)
            os.Setenv("TF_ACC", "")
            ^
    helper/schema/schema_test.go:8484:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorDefaultsFalse (tenv)
            os.Setenv("TF_ACC", oldEnv)
            ^
    helper/schema/schema_test.go:8490:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorTF_ACCSet (tenv)
            os.Setenv("TF_ACC", "1")
            ^
    helper/schema/schema_test.go:8495:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorTF_ACCSet (tenv)
            os.Setenv("TF_ACC", oldEnv)
            ^
    ```
    bflad committed Apr 11, 2022
    Copy the full SHA
    47b28ee View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG for #934

    bflad committed Apr 11, 2022
    Copy the full SHA
    7740e6f View commit details
    Browse the repository at this point in the history