Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate go toolchain and add changelog for Go version bump to 1.21 #1318

Merged
merged 4 commits into from Apr 19, 2024
Merged

Reinstate go toolchain and add changelog for Go version bump to 1.21 #1318

merged 4 commits into from Apr 19, 2024

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Feb 29, 2024 •
edited

Reference: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175

  • Adding a change log entry for the bump to Go 1.21.
  • Reinstating the go toolchain directive in go.mod.
  • Updating CI and docs to reflect update to Go 1.21.

@bendbennett bendbennett added the dependencies Pull requests that update a dependency file label Feb 29, 2024
@bendbennett bendbennett added this to the v2.33.1 milestone Feb 29, 2024
@bendbennett bendbennett requested a review from a team as a code owner February 29, 2024 14:50
austinvalle
austinvalle approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀 , ref: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175

@bflad bflad modified the milestones: v2.33.1, v2.34.0 Apr 19, 2024
@austinvalle austinvalle merged commit 68d9c93 into main Apr 19, 2024
8 checks passed
@austinvalle austinvalle deleted the bendbennett/bump-go-1.21 branch April 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v2.34.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendbennett @austinvalle @bflad